Refactor Confirmation Dialogs and Event Handling in Dashboard#730
Open
tofoli wants to merge 1 commit intosplitrb:mainfrom
Open
Refactor Confirmation Dialogs and Event Handling in Dashboard#730tofoli wants to merge 1 commit intosplitrb:mainfrom
tofoli wants to merge 1 commit intosplitrb:mainfrom
Conversation
- Removed the unused confirmStep function. - Added event listeners for confirmation dialogs using class-based selectors for better maintainability. - Updated form elements to use class names for triggering confirmation dialogs instead of inline onclick attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the confirmation dialog handling in the Split dashboard. The changes improve the maintainability of the code by removing unused functions and replacing inline event handlers with class-based event listeners.
Changes Made
confirmStepfunction as it was not utilized._controls.erband_experiment.erbviews to use class names instead of inlineonclickattributes for triggering confirmation dialogs.Benefits